apache / apache/cordova-plugin-dialogs
Don't specify light theme on Android
Open
- Dominant language
- JavaScript
- Stars
- 294
- Forks
- 352
- PR merge metrics
- No merged PRs in 30d
Description
The dialogs plugin on Android has the light theme hardcoded. I think the plugin shouldn't try to guess what's best, and let the app and/or the platform decide the theme the apply (usually based on the default device theme and the target SDK of the app). Is there a good reason for the dialogs plugin to assume that using the light theme unconditionally is the right way to go?
Contributor guide
Assessment
This issue has not been assessed yet.