apache / apache/cordova-node-xcode

Allow comma in buildSettings

Open
#86 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
217
Forks
102
Avg merge
2d 3h
Merged PRs (30d)
6

Description

when i try to set "TARGETED_DEVICE_FAMILY", it failed.
buildSettingsObj.TARGETED_DEVICE_FAMILY = '1,2'

```
While preparing Cordova project for platform iOS:
SyntaxError: Expected ".", "/*", ";", or [0-9] but "," found.
at peg$buildStructuredError (/Users/monsterstep/.meteor/packages/meteor-tool/.1.9.0.1eehdch.kfff++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/cordova-lib/node_modules/xcode/lib/parser/pbxproj.js:412:12)
at Object.peg$parse [as parse] (/Users/monsterstep/.meteor/packages/meteor-tool/.1.9.0.1eehdch.kfff++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/cordova-lib/node_modules/xcode/lib/parser/pbxproj.js:1886:11)
```

the xcodeproj has value like this

![image](https://user-images.githubusercontent.com/1147704/74629486-49e4df80-5193-11ea-9c87-73ffdf6929c2.png)

![image](https://user-images.githubusercontent.com/1147704/74628318-63385c80-5190-11ea-8b4c-5c3dc751e6a1.png)

https://github.com/apache/cordova-node-xcode/issues/57

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.