apache / apache/cordova-electron
Unable to pass Publish options to electron-builder
- Dominant language
- JavaScript
- Stars
- 135
- Forks
- 60
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 5
Description
# Bug Report
## Problem
### What is expected to happen?
I am able to pass configuration to electron-builder to define Publish parameters.
### What does actually happen?
I am unable to pass parameters correctly through to electron-builder. It seems that the way cordova-electron intermediates between the developer and electron-builder is unnecessarily complex and leads to errors and problems with the ability to configure electron-builder.
According to the documentation for electron-builder, you should be able to pass through "publish" options as a top-level object, or per platform or per target: https://www.electron.build/configuration/publish
## Information
According to the documentation for cordova-electron, the only valid keys for the "electron" config object in the `build.json` file are "mac", "windows" and "linux". Anything else is ignored and not passed through to electron-builder in the `builder-effective-config.yaml` file.
### Command or Code
### Environment, Platform, Device
### Version information
## Checklist
- [x ] I searched for existing GitHub issues
- [ x] I updated all Cordova tooling to most recent version
- [ x] I included all the necessary information above
Contributor guide
Research direction
Start by tracing how the electron config in build.json is converted into builder-effective-config.yaml and compare that with electron-builder's documented publish options. Reproduce the configuration pass-through failure, then verify that top-level or platform/target publish parameters reach electron-builder without breaking the existing mac, windows, and linux keys.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100