apache / apache/cordova-common

Not possible to disable backup, because of config conflicts are handled

Open
#153 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
42
Forks
45
Avg merge
5h 41m
Merged PRs (30d)
6

Description

# Bug Report

I would like to set the following setting in my config.xml , to disable backups as it can result in major problems with state.
However, that's not possible if you have plugins that also alter AndroidManifest.xml application, ie `requestLegacyExternalStorage ` as has also been introduced in the master branch of cordova-file.

Config.xml
```

```

plugin.xml
```

```

```
Failed to install 'cordova-plugin-file': Error: cordova-plugin-file cannot be added. changes in this plugin conflicts with changes in config.xml. Conflicts must be resolved before plugin can be added.
```

## Problem
I can't disable android backup, and use plugins like `cordova-file` from master branch, or `telerik-image-picker` because they have the same "target", not because they actually conflict.
This is also a problem because many others target the same xml element, because it hosts a lot of application settings as per the Android Documentation: [https://developer.android.com/guide/topics/manifest/application-element](url)

### What is expected to happen?
Android backup is disabled, plugins are useable

### What does actually happen?
Conflict checker cancels plugin install on Android platform.

## Information

### Command or Code

with the following added to config.xml

```

```

`Cordova Plugin add cordova-plugin-telerik-imagepicker@latest`

or
`cordova plugin add https://github.com/apache/cordova-plugin-file/`

### Environment, Platform, Device

Cordova-Android 9.0

### Version information

Cordova CLI 10.0.0
Cordova Android 9.0.0
Cordova Plugin Telerik ImagePicker 2.3.5
Cordova Plugin File@Master

## Checklist

- [x] I searched for existing GitHub issues
- [x] I updated all Cordova tooling to most recent version
- [x] I included all the necessary information above

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the conflict checker behavior described in the issue and the supplied config.xml and plugin.xml edit-config examples. Check how changes targeting the same AndroidManifest.xml element are treated when adding a plugin; done means the config.xml backup setting and a plugin's separate application setting can both be used without installation being rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.