apache / apache/cordova-android

Breaking change in cordova-android@15.0.0: renaming strings.xml to cdv_strings.xml

Open
#1,922 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
1.6k
Avg merge
16h 18m
Merged PRs (30d)
11

Description

# Bug Report

In #1818 (*feat!: add partial night & day theme support*) the commit included a change to rename `strings.xml` in the generated Android Studio project to `cdv_strings.xml`. This appears to be an undocumented breaking change going from cordova-android@14.0.1 to cordova-android@15.0.0 and has broken one of our Cordova plugins. We have the following in our plugin.xml:

```xml

$APP_ID

```

This refers to a file named `strings.xml` specifically rather than `cdv_strings.xml`. To support cordova-android@15, we have to change the file name. To support both I guess we need to have the tag twice to specify both names. Presumably any other Cordova plugins that similarly target strings.xml, themes.xml or colors.xml will also be broken for the same reason.

## Problem

### What is expected to happen?

Preserve filenames of strings.xml et al. for backwards compatibility, or clearly document a breaking change.

### What does actually happen?

Undocumented breaking change in cordova-android@15.0.0.

## Checklist

- [ ] I searched for existing GitHub issues
- [ ] I updated all Cordova tooling to most recent version
- [ ] I included all the necessary information above

Contributor guide

Open the contributing guide

Research direction

Start by reviewing commit #1818 and the generated Android Studio project's resource filenames, then inspect the plugin.xml config-file target shown in the report. Determine whether backwards-compatible names can be preserved or whether the strings.xml, themes.xml, and colors.xml changes require documentation, and verify the result against plugins supporting both cordova-android@14.0.1 and @15.0.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.