apache / apache/cordova-android

config-file doesn't remove from AndroidManifest.xml added-deleted settings

Open
#1,633 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
1.6k
Avg merge
16h 18m
Merged PRs (30d)
11

Description

# Bug Report

## Problem

If I add a custom setting to the config.xml file using config-file, build, and later I delete it, and build again, the custom setting will remain in the AndroidManifest.xml

### What does actually happen?

1. Add a custom setting to the config.xml file using config-file, by example "testx":


.....


2. Run cordova build android. The AndroidManifest.xml is modified and the custom setting "testx" is added:

3. Delete the custom setting "testx":


.....

3. Run cordova build android. The "testx" remains in the AndroidManifest.xml.

I tried remove it directly from the AndroidManifest.xml but the custom settings appers again on build.

### What is expected to happen?

The custom settings should be removed.

### Version information
cordova-lib@12.0.1
node v16.20.0
windows 11

## Checklist

- [x] I searched for existing GitHub issues
- [x] I updated all Cordova tooling to most recent version
- [x] I included all the necessary information above

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by adding a custom setting in config.xml, running cordova build android, removing the setting, and building again. Inspect how config-file changes are applied to AndroidManifest.xml. Done means a setting removed from config.xml no longer remains in AndroidManifest.xml after a subsequent build.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.