apache / apache/cloudstack

methods implemented twice in marvin code

Open
#5,174 3 comments 0 reactions 0 assignees View on GitHub
component:marvin no-issue-activity status:stale status:testing type:cleanup type:technical-debt
Dominant language
Java
Stars
3.1k
Forks
1.4k
Avg merge
6d 19h
Merged PRs (30d)
32

Description

in the marvin python code some methods are implemented twice.
example:
format_volume_to_ext3(ssh_client, device="/dev/sda") in `marvin/lib/util.py` and in `marvin/sandbox/demo/simulator/testcase/libs/utils.py`

more can surely be found.

##### ISSUE TYPE

* Bug Report
* Improvement Request
* Enhancement Request
* Feature Idea
* Documentation Report
* Other

##### COMPONENT NAME

~~~

~~~

##### CLOUDSTACK VERSION

~~~

~~~

##### CONFIGURATION

##### OS / ENVIRONMENT

##### SUMMARY

##### STEPS TO REPRODUCE

~~~

~~~

##### EXPECTED RESULTS

~~~

~~~

##### ACTUAL RESULTS

~~~

~~~

Contributor guide

Open the contributing guide

Research direction

Start by comparing format_volume_to_ext3 in marvin/lib/util.py with the duplicate in marvin/sandbox/demo/simulator/testcase/libs/utils.py. Search the marvin Python code for other duplicated methods and determine which implementations should remain. Done means duplicate implementations have been consolidated without changing the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.