apache / apache/celix

Unified Error Codes for libdfi

Open
#724 0 comments 0 reactions 1 assignee Claimed by @PengZheng View on GitHub
component/dfi kind/improvement
Dominant language
C
Stars
193
Forks
99
Avg merge
1m
Merged PRs (30d)
1

Description

# Intro

Currently each component (by component we mean .h/.c pair, which is borrowed from Lakos' Large Scale C++) in libdfi has its own error code definition:

In `dyn_function.c`, we have:

```C
static const int OK = 0;
static const int ERROR = 1;
```

In `dyn_type.c`, there is:

```C
static const int OK = 0;
static const int ERROR = 1;
static const int MEM_ERROR = 2;
static const int PARSE_ERROR = 3;
```

# Unified Error Codes

Given that celix_status_t now support a custom facility error part, I think the int return can be upgraded to a celix_status_t. And because celix_status_t is a typedef to int, this maybe is even backwards compatible.

But this would be nice as a future enhancement and port of this pull request.

_Originally posted by @pnoltes in https://github.com/apache/celix/pull/699#discussion_r1471690851_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.