apache / apache/celix

run_unit_test_discovery_zeroconf failure in Conan2 port branch

Open
#618 0 comments 1 reaction 1 assignee Claimed by @xuzhenbao View on GitHub
Dominant language
C
Stars
193
Forks
99
Avg merge
1m
Merged PRs (30d)
1

Description

```
[ RUN ] DiscoveryZeroconfAnnouncerTestSuite.AddAndRemoveEndpoint
[2023-08-20T12:42:38] [ info] [celix_framework] [framework_start:476] Celix framework started
[2023-08-20T12:42:38] [ error] [DiscoveryZeroconf] Announcer: Failed to create connection for DNS service, -65563.
[2023-08-20T12:42:38] [ info] [DiscoveryZeroconf] Announcer: Add endpoint for dzc_test_service(60f49d89-d105-430c-b12b-93fbb54b1d19).
[2023-08-20T12:42:38] [ error] [DiscoveryZeroconf] Announcer: Failed to create connection for DNS service, -65563.
/home/runner/work/celix/celix/bundles/remote_services/discovery_zeroconf/gtest/src/DiscoveryZeroconfAnnouncerTestSuite.cc:218: Failure
Expected equality of these values:
dnsErr
Which is: -65563
kDNSServiceErr_NoError
Which is: 0
[2023-08-20T12:42:38] [ info] [DiscoveryZeroconf] Announcer: Remove endpoint for dzc_test_service(60f49d89-d105-430c-b12b-93fbb54b1d19).
[2023-08-20T12:42:38] [ error] [DiscoveryZeroconf] Announcer: Failed to create connection for DNS service, -65563.
[ FAILED ] DiscoveryZeroconfAnnouncerTestSuite.AddAndRemoveEndpoint (6 ms)
```

https://github.com/apache/celix/tree/feature/483-conan-2-support
CI still uses Conan 1 to run these tests.

The test failed because it failed to find mdnsd.
The test specify mdnsd's location by `-DMDNSD="${DNSSD_LIB_DIRS}/../bin/mdnsd"`, and Conan2 generators does not have `DNSSD_LIB_DIRS`.

Currently, I replace `DNSSD_LIB_DIRS` by `DNSSD_INCLUDE_DIR` as a stop gap.
But a proper fix IMO should use information provided by Conan @xuzhenbao:

```python
# add path for daemon (mdnsd, mDNSResponder) and client (dns-sd)
bin_path = os.path.join(self.package_folder, "bin")
self.output.info("Appending PATH environment variable: {}".format(bin_path))
self.env_info.PATH.append(bin_path)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.