apache / apache/camel-k

Re evaluate golanci-lint exclusions

Open
#5,486 4 comments 2 reactions 0 assignees View on GitHub
area/build-operator area/continuous integration good first issue status/never-stale
Dominant language
Go
Stars
927
Forks
387
Avg merge
15h 5m
Merged PRs (30d)
36

Description

### Requirement

We should reduce the number of excluded linters to the are minimum.

### Problem

Some linters are very useful, like those about complexity or other common best practices but they are disbaled for some reason.

### Tasks
We must enable them in https://github.com/apache/camel-k/blob/main/.golangci.yml:

- [ ] cyclop
- [ ] depguard
- [x] dupl
- [ ] exhaustive
- [ ] exhaustivestruct
- [ ] exhaustruct
- [ ] forbidigo
- [ ] funlen
- [ ] gci
- [ ] gochecknoglobals
- [ ] gochecknoinits
- [ ] gocognit
- [ ] gocyclo
- [ ] godox
- [ ] err113
- [ ] gofumpt
- [ ] gomnd
- [ ] ireturn
- [x] lll
- [x] nestif
- [ ] nilnil
- [ ] nlreturn
- [x] nolintlint
- [ ] paralleltest
- [ ] revive
- [ ] tagalign
- [x] tagliatelle
- [ ] testpackage
- [ ] varnamelen
- [x] wastedassign
- [x] whitespace
- [ ] wrapcheck
- [ ] wsl
- [x] execinquery
- [x] mnd
- [ ] perfsprint
- [x] goconst

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with .golangci.yml and review the currently disabled linters listed in the issue, comparing them with the enabled configuration. Work through the unchecked entries, keeping only exclusions that are still justified. Done means the minimum necessary exclusions remain and the configuration passes the project's lint checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.