apache / apache/buildstream

bst artifact pull: 'artifact not found' is success

Open
#970 4 comments 0 reactions 0 assignees View on GitHub
frontend
Dominant language
Python
Stars
140
Forks
45
Avg merge
1d 3h
Merged PRs (30d)
6

Description

[See original issue on GitLab](https://gitlab.com/BuildStream/buildstream/-/issues/970)
In GitLab by [[Gitlab user @aevri]](https://gitlab.com/aevri) on Mar 21, 2019, 17:50

## Summary

[//]: # (Summarize the bug encountered concisely)

If you try to `bst artifact pull` an artifact that the server does not have, the command exits with code `0` and prints 'SUCCESS'.

It seems that it should exit with non-zero and print less positive text about the operation.

## Steps to reproduce

[//]: # (How one can reproduce the issue - this is very important)

```bash
git clone https://gitlab.com/buildstream/buildstream.git
cd buildstream/doc/examples/running-commands

REPO=$(mktemp -d)
bst-artifact-server "$REPO" -p 8888 &

cat >>project.conf <

Contributor guide

Open the contributing guide

Research direction

Start in doc/examples/running-commands and reproduce the behavior with bst artifact pull hello.bst against an empty bst-artifact-server repository. Trace how the skipped pull affects the final pipeline summary and exit code; done means a missing artifact reports failure, includes the artifact context, and exits non-zero as shown in the expected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.