apache / apache/buildstream

Follow-up from "WIP: Optimize consistency and state handling"

Open
#1,236 0 comments 0 reactions 0 assignees View on GitHub
enhancement refactoring tests
Dominant language
Python
Stars
140
Forks
45
Avg merge
1d 3h
Merged PRs (30d)
6

Description

[See original issue on GitLab](https://gitlab.com/BuildStream/buildstream/-/issues/1236)
In GitLab by [[Gitlab user @BenjaminSchubert]](https://gitlab.com/BenjaminSchubert) on Dec 10, 2019, 15:00

The following discussion from !1739 should be addressed:

- [ ] [[Gitlab user @tlater]](https://gitlab.com/tlater) started a [discussion](https://gitlab.com/BuildStream/buildstream/merge_requests/1739#note_252256541): (+4 comments)

> I don't think these method names are correct.

It turns out that we don't seem to have tests that contain the sources in their own source-based cache and not in the cas.

We should write tests to ensure the behavior is correct here.

Contributor guide

Open the contributing guide

Research direction

Start with the linked GitLab issue and the discussion from merge request !1739, focusing on the source-based cache and CAS behavior. Add tests covering sources present in their own source-based cache but absent from the CAS, and verify the expected behavior described by the discussion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.