apache / apache/buildstream

Use fixture for creating artifact shares in testing

Open
#1,113 2 comments 0 reactions 0 assignees View on GitHub
enhancement tests
Dominant language
Python
Stars
140
Forks
45
Avg merge
1d 3h
Merged PRs (30d)
6

Description

[See original issue on GitLab](https://gitlab.com/BuildStream/buildstream/-/issues/1113)
In GitLab by [[Gitlab user @traveltissues]](https://gitlab.com/traveltissues) on Aug 29, 2019, 14:27

Many tests involving artifacts duplicate code to setup a share, this should probably be a fixture instead: eg. https://gitlab.com/BuildStream/buildstream/merge_requests/1568#note_209844456

Contributor guide

Open the contributing guide

Research direction

Start by locating tests that duplicate setup for artifact shares and review the referenced GitLab merge request 1568 for context. The work is done when the repeated setup is replaced with a shared fixture and the affected tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.