apache / apache/brpc

EINVAL返回码触发熔断问题

Open
#728 6 comments 0 reactions 0 assignees View on GitHub
feature
Dominant language
C++
Stars
17.6k
Forks
4.1k
Avg merge
2d 12h
Merged PRs (30d)
69

Description

在熔断文档中[提到](https://github.com/apache/incubator-brpc/blob/master/docs/cn/circuit_breaker.md#%E9%BB%98%E8%AE%A4%E7%9A%84%E7%86%94%E6%96%AD%E7%AD%96%E7%95%A5), 服务端返回EINVAL会导致熔断判定.

但按照我的理解, EINVAL是一个比较常见的返回码, 导致EINVAL的原因可能在客户端, 也可能在服务端, 错误可能是暂时的, 也可能是长期的. 不知道在设计之初, 是基于什么考虑, 将EINVAL也包括在触发熔断的错误类别中?

多谢~

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.