apache / apache/brpc

增加协议不修改已有协议的值

Open
#460 2 comments 0 reactions 0 assignees View on GitHub
enhancement official
Dominant language
C++
Stars
17.6k
Forks
4.1k
Avg merge
2d 12h
Merged PRs (30d)
69

Description

目前brpc增加了thrift Protocol,但是这个Protocol是插入在Protocol num中间了,改变了以前协议的num值,可能会让使用动态库的场景向前兼容失效。一般我们会把动态库的更新和可执行程序(服务)的更新分开,这样如果协议enum值改了,我们只更新了程序或者只更新了brpc库,都会导致.h和.so里的enum值对不上,而在这样的情况下,保证.so和程序同时更新又很困难。

+ PROTOCOL_REDIS = 17,
+ PROTOCOL_MEMCACHE = 18,

- PROTOCOL_REDIS = 16,
- PROTOCOL_MEMCACHE = 17,

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.