apache / apache/brpc

这两句同步语句是否可以合并为

Open
#2,417 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
17.6k
Forks
4.1k
Avg merge
2d 12h
Merged PRs (30d)
69

Description

![image](https://github.com/apache/brpc/assets/17529657/0a584efb-7d5d-4791-9b99-1d0f31996e45)

合并为 ` b = _bottom.load(butil::memory_order_seq_cst);`
不知道这里为什么要加两个fence

Contributor guide

Open the contributing guide

Research direction

Locate the synchronization statements shown in the issue and inspect the surrounding code that accesses _bottom. Compare the proposed atomic load with the existing fences under the relevant concurrency assumptions; done means the maintainers have a justified decision about whether the statements can be merged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.