apache / apache/bookkeeper

Clean up internal Bookkeeper constructors

Open
#577 2 comments 0 reactions 0 assignees View on GitHub
jiramigrated triage/18-w13 triage/week-33 type/improvement
Dominant language
Java
Stars
2k
Forks
976
Avg merge
6d 15h
Merged PRs (30d)
7

Description

JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-1011

Reporter: Robert Joseph Evans @revans2

One of the feedbacks from

https://github.com/apache/bookkeeper/pull/105#issuecomment-287787603

was that there are some customer APIs that need to be cleaned up. This is specifically for the two constructors in Bookkeeper

{code}
public BookKeeper(ClientConfiguration conf, ZooKeeper zk);
public BookKeeper(ClientConfiguration conf, ZooKeeper zk, ClientSocketChannelFactory channelFactory);
{code}

That are really for internal use only. We should find a way to mark them as such.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.