apache / apache/bookkeeper

Error paths in Bookie.start() don't stop the LifecycleComponent in Main.doMain

Open
#1,891 0 comments 0 reactions 1 assignee Claimed by @sijie View on GitHub
area/bookie triage/week-8
Dominant language
Java
Stars
2k
Forks
976
Avg merge
6d 15h
Merged PRs (30d)
7

Description

It looks to me like calling shutdown() in the error paths doesn't actually result in the LifecycleComponent in Main.doMain shutting down. Normally, the DeathWatcher will raise an exception which'll be caught by the exception handler set in startComponent, but BookieServer.start() doesn't do that if the Bookie isn't running after start(). I think we just need to raise an exception in that branch in BookieServer.start().

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.