apache / apache/beam

[Task][Go SDK][Cleanup]: Migrate passert package exclusively to the generic register package.

Open
#27,567 1 comment 0 reactions 0 assignees View on GitHub
go P3 stale task
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

### What needs to happen?

The go generate lines would need to be removed:
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.go#L31

and the registrations in `passert.shims.go` https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/testing/passert/passert.shims.go should be moved to `init()` blocks using the register package instead.

Partially done in #27565, this will be easier to work on once prism is the default runner, since the error unregistered portions will be provided as test failures. See #24789

### Issue Priority

Priority: 3 (nice-to-have improvement)

### Issue Components

- [ ] Component: Python SDK
- [ ] Component: Java SDK
- [X] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.