[Task]: Re-use BatchConverterTest for different implementations
Open
dataframe
dsl
P2
task
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 4.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 196
Description
### What needs to happen?
We have `BatchConverterTest` in `batch.py`, which is used to test the list and numpy implementations. As more `BatchConverter` implementations are added they will need to add tests that are almost identical to this one, with a few alterations:
- The test data, currently handled with `parameterized_class`.
- Possibly a custom equality check (e.g. `pd.testing.assert_frame_equal` for pandas)
We should make it possible to re-use the tests in `BatchConverterTest` without copy-pasting it, as this will lead to fragmentation.
### Issue Priority
Priority: 2
### Issue Component
Component: dsl-dataframe
Contributor guide
Assessment
This issue has not been assessed yet.