apache / apache/beam

Potential Refactoring

Open
#22,059 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

**Summary**
I have identified a few classes with refactoring potential, specifically DataflowPipelineOptions.java. The class was refactored once on Sep 4, 2020 along with other classes in commit 0542e260cc58a8e941faaeb1b4ee30bb7a04d7d0 . Given the duration of the last refactoring, could it be possible to improve this class further? I am probably not qualified and experienced enough to point out the exact code needs to be refactored, given my limited knowledge of the project and codebase.

**Urgency**
Low priority. For maintenance of code in the long run.

Hi,
I am currently doing some research on Estimating Time Taken for Software Refactoring. Beam is one of my case studies being a highly popular project. Would appreciate your kind feedback on the appropriateness of the estimated time to refactor.
I am specifically looking at potential for refactoring, such as breaking functions that are too long into shorter functions, or to remove code duplication. Would you agree that there could be some modification to the code to make it better in the listed classes? And if so, is the estimated time appropriate to carry out the improvement? I will be grateful for any help you can provide.

1. DataflowPipelineOptions.java - 4 hours
2. DefaultGcpRegionFactory.java - 2 hours
3. DataflowPipelineOptionsTest.java - 5 hours
4. DataflowRunnerTest.java - 4 hours

Thank you.

Regards,
Alvin

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.