apache / apache/beam

MemoryMonitor only uploads to GCS on restart

Open
#21,343 0 comments 0 reactions 0 assignees View on GitHub
harness improvement java P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

The current MemoryMonitor has an option to upload a profile to GCS. However it only uploads the profile to GCS when starting the memory monitor thread. This is currently done when the harness is started only.

However MemoryMonitor's tryToDumpHeap is public and therefore can be called clients at any point (e.g. not only on worker restart). In this case we do not upload to GCS until the harness restarts which is not good end user behavior. It's currently called by StreamingDataflowWorker at a point of high memory but before the worker will actually crash, which is how we caught this behavior.

Probably we should add a boolean to tryToHeapDump to get an idea for if the worker is about to die or if this is a pre-emptive dump. If it's pre-emptive we can probably immediately upload it to GCS as well if so configured.

Imported from Jira [BEAM-13718](https://issues.apache.org/jira/browse/BEAM-13718). Original Jira may contain additional context.
Reported by: laraschmidt.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.