apache / apache/beam

There should be single source of truth for the project version

Open
#21,302 7 comments 0 reactions 1 assignee Claimed by @kennknowles View on GitHub
build P3 wish
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Now the Beam version is defined in two places:
* via the 'version' parameter [in gradle.properties](https://github.com/apache/beam/blob/master/gradle.properties#L27),
* programmatically in the `apply` function [in BeamModulePlugin](https://github.com/apache/beam/blob/cd653e33b342bd09c76c2bbaca12597fec5b4a2c/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L494)

The latter effectively overrides the former. For someone not very familiar with the Beam build system this may result in a hard to understand and debug behavior: unexpected version gets build and/or pushed to local Maven repository, and changing version in `gradle.properties` does not have any effect.

Adding a comment with a reference to `BeamModulePlugin` to `gradle.properties` can be a good start, and in the long run it would be great to have single source of truth for the project version.

 

 

Imported from Jira [BEAM-14051](https://issues.apache.org/jira/browse/BEAM-14051). Original Jira may contain additional context.
Reported by: dmitryor.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.