apache / apache/beam

IsmSideInputReaderTest.verifyMap does not make some contains assertions

Open
#21,294 0 comments 0 reactions 0 assignees View on GitHub
bug dataflow P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

See for example https://github.com/apache/beam/blob/a8162f2fe92fbc982f72289dfca7b56f1fdb0762/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java#L1579

There are three such "assertions" in verifyMap. When these are made into actual assertions (e.g. using assertTrue), the test fails.

Imported from Jira [BEAM-13460](https://issues.apache.org/jira/browse/BEAM-13460). Original Jira may contain additional context.
Reported by: bhulette.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.