apache / apache/beam

Use ProjectionConsumer in FieldAccessVisitor.

Open
#21,276 0 comments 0 reactions 0 assignees View on GitHub
core improvement java P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

I created an interface for ProjectionConsumer and then neglected to use it. Using ProjectionConsumer rather than handling transforms case-by-case will make FieldAccessVisitor easier to extend.

Changing this would require ParDo.MultiOutput to implement ProjectionConsumer.

https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/ProjectionConsumer.java

https://github.com/apache/beam/blob/8a7ad0edd0ffe2a7b23efbe37567cf03aed82262/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/FieldAccessVisitor.java#L64

Imported from Jira [BEAM-13431](https://issues.apache.org/jira/browse/BEAM-13431). Original Jira may contain additional context.
Reported by: ibzib.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.