apache / apache/beam

Delete orphaned files

Open
#21,269 0 comments 0 reactions 0 assignees View on GitHub
bug files io P2 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Until version 2.33.0 of Apache Beam, (tested with a Python streaming pipeline consuming events from PubSub and writing them into GCS), some files were being deleted from the temporary folder before being moved to the destination. This was the original issue: 

https://issues.apache.org/jira/browse/BEAM-12950

In version 2.34.0 we applied a temporary workaround to be sure that no data is dropped. Instead of deleting the orphaned files, we just log them:

[https://github.com/apache/beam/pull/15576](https://github.com/apache/beam/pull/15576)

Most probably the root cause of the missing event was that we were removing files at an erroneous time. We need to delete orphaned files in a subsequent step (after we're sure that there won't be retries). 

Once the original issue is fixed and the orphaned files are deleted at the correct time, we should remove the decorator of the unit test skipped in the Pull Request above.  

Imported from Jira [BEAM-13010](https://issues.apache.org/jira/browse/BEAM-13010). Original Jira may contain additional context.
Reported by: davidpr.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.