apache / apache/beam

error-prone UnusedVariable check raises false positives for StateId and TimerId usages

Open
#21,230 0 comments 0 reactions 0 assignees View on GitHub
core java P3 task
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
2d 2h
Merged PRs (30d)
205

Description

See https://github.com/google/error-prone/issues/2668. The next release of error-prone will contain https://github.com/google/error-prone/pull/2669 and https://github.com/google/error-prone/pull/2676, which will help us.

Until then we've had to suppress the check in several places. This jira tracks upgrading to a new error-prone once released and removing the suppressions.

Imported from Jira [BEAM-13271](https://issues.apache.org/jira/browse/BEAM-13271). Original Jira may contain additional context.
Reported by: bhulette.

Contributor guide

Open the contributing guide

Research direction

Review the linked Error Prone issue and pull requests 2669 and 2676 first, then locate the existing suppressions for the UnusedVariable check in the Beam repository. Upgrade Error Prone after the fix is released, remove the suppressions, and verify that the project builds and the affected checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.