apache / apache/beam

Improve textio: Write sharding

Open
#21,031 1 comment 0 reactions 0 assignees View on GitHub
go improvement P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

The other SDKs have implementations that shard files on write. So should the Go SDK. The feature is mentioned in the Beam Programming Guide:

[https://beam.apache.org/documentation/programming-guide/#file-based-writing-multiple-files](https://beam.apache.org/documentation/programming-guide/#file-based-writing-multiple-files)

It would be expedient to provide an Xlang TextIO implementation for the Go SDK compared to replicating the implementation in Go, at cost of some execution time performance.

Ideally it would be similarly generalized to simplify writing File Sinks.  File sinks are necessarily complex to provide a robust and reliable implementation

Current Go implementation.

[https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/textio/textio.go#L119](https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/textio/textio.go#L119)

Python FileIO implementation:

[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filebasedsink.py](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filebasedsink.py) 

(Note iobase.Sink is deprecated, but is still suitable for file io.)

Java TextIO & FileIO:

[https://github.com/apache/beam/blob/f8fbbfa309ac88848057de694d4cc1cba3eaa92a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java#L1259](https://github.com/apache/beam/blob/f8fbbfa309ac88848057de694d4cc1cba3eaa92a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java#L1259) 

[https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java) 

 

KafkaIO (example of writing Go SDK side wrapper for a xlang Java IO):

[https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/xlang/kafkaio/kafka.go](https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/xlang/kafkaio/kafka.go) 

 

General docs on writing sinks: [https://beam.apache.org/documentation/io/developing-io-overview/#sinks](https://beam.apache.org/documentation/io/developing-io-overview/#sinks) 

 

Imported from Jira [BEAM-12664](https://issues.apache.org/jira/browse/BEAM-12664). Original Jira may contain additional context.
Reported by: lostluck.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.