apache / apache/beam

Language tabs break if highlight shortcodes are not adjacent.

Open
#21,030 2 comments 0 reactions 1 assignee Claimed by @04pallav View on GitHub
bug P3 website
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

If adjacent `\`< highlight >`` shortcodes have an extra return between them, it breaks the language switcher tabs. This appears to be happening because the Markdown parser generates empty `` tags for the return. This doesn't happen in all circumstances. It seems to happen if the first shortcode is preceded by a text element and _no_ return. The jQuery in language-switch-v2.js doesn't expect the `` tags, and the CSS probably doesn't either.

It _may_ be possible to fix this by removing `` tags. We shouldn't touch the Hugo markdown parser or builtin shortcodes.

 

 

Imported from Jira [BEAM-12688](https://issues.apache.org/jira/browse/BEAM-12688). Original Jira may contain additional context.
Reported by: pcoet.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.