Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?
Open
core
improvement
java
P3
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 4.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 196
Description
https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215
Can we remove the "final" modifier here so subclasses have the option to override? I have a subclass implementation that performs best with a different size estimation heuristic. Similar case with the #split method.
Imported from Jira [BEAM-10604](https://issues.apache.org/jira/browse/BEAM-10604). Original Jira may contain additional context.
Reported by: clairemcginty.
Contributor guide
Assessment
This issue has not been assessed yet.