apache / apache/beam

warn or error when constructor runner != options runner

Open
#19,982 0 comments 0 reactions 0 assignees View on GitHub
core improvement P3 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Right now, the runner set in the Pipeline constructor silently overrides the runner set in pipeline options [1]. This can result in subtle errors, where a different runner is used than expected [2]. I can't imagine any legitimate reason anyone would want to do this, so we should error when they contradict each other, or at least warn.

[1] https://github.com/apache/beam/blob/e20b0c213034cd438d48f4a2cb56cc902dae023f/sdks/python/apache_beam/pipeline.py#L179-L186
[2] https://github.com/tensorflow/tfx/blob/02ead9886726cf2cebd9a3d1e1b4bbd0f2cf9d00/tfx/components/base/base_executor.py#L142-L143

Imported from Jira [BEAM-9438](https://issues.apache.org/jira/browse/BEAM-9438). Original Jira may contain additional context.
Reported by: ibzib.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.