apache / apache/beam

Reference to ParallelBundleManager attr "_skip_registration" should be "_registered"

Open
#19,920 0 comments 0 reactions 0 assignees View on GitHub
bug core P3 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

It appears there was a mistake in the multiprocess refactor of the BundleManager. I came across this issue while getting mypy type analysis setup (score one for static type checking!)

The offending line is here: https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L933

I think it should be using "_registered", as seen here: https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L1909

I can easily change the attribute name, but presumably this will change the behavior. Hopefully for the better, but I don't know enough to say.

Imported from Jira [BEAM-8486](https://issues.apache.org/jira/browse/BEAM-8486). Original Jira may contain additional context.
Reported by: chadrik.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.