apache / apache/beam

Expansion of _CombinePerKeyWithHotKeyFanout has no typehints

Open
#19,885 0 comments 0 reactions 0 assignees View on GitHub
bug core P3 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

The expansion of [_CombinePerKeyWithHotKeyFanout](https://github.com/apache/beam/blob/bd09a038f4df896ef6d903a4944083fcd2e8f727/sdks/python/apache_beam/transforms/core.py#L1913), which is used by [CombinePerKey.with_hot_key_fanout()](https://github.com/apache/beam/blob/bd09a038f4df896ef6d903a4944083fcd2e8f727/sdks/python/apache_beam/transforms/core.py#L1734), uses DoFns (SplitHotCold) and CombineFns (PreCombineFn, PostCombineFn) and a lambda (SplitNonce) that have no typehints. If the user specified a typehints on the original CombineFn, the typehints are lost. This means that the fallback coder rather than the user specified coder.

Imported from Jira [BEAM-8520](https://issues.apache.org/jira/browse/BEAM-8520). Original Jira may contain additional context.
Reported by: myffical@gmail.com.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.