apache / apache/beam

cut_release_branch.sh should not push to master without verification and a PR

Open
#19,759 0 comments 0 reactions 0 assignees View on GitHub
build P3 sub-task
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Currently, the cut_release_branch.sh does many things:

- Edits files in place to update the version
- Makes a local commit
- Pushing the local commit to master
- Creates a new branch
- Edits files in place to update the version
- Pushes the release branch

I think all of this except the push to master are OK. It is possible that we have something - website, examples, new places where the version is hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to (x****1)-SNAPSHOT is easy to do in a pull request and safe. The release branch creation does not need to be synchronized with this.

Imported from Jira [BEAM-6441](https://issues.apache.org/jira/browse/BEAM-6441). Original Jira may contain additional context.
Reported by: kenn.
This issue has child subcomponents which were not migrated over. See the original Jira for more information.
Subtask of issue #19755

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.