apache / apache/beam

Finish migration to standard Python typing

Open
#19,738 0 comments 0 reactions 0 assignees View on GitHub
core improvement P3 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

We should migrate all Python uses of types to the standard typing module, and make the typehints.* ones aliases of the Python ones. 

 

There are three places where we use custom typehints behavior: 

(1) is_compatible_with

(2) bind_type_variables/match_type_variables

(3) trivial type inference. 

 

I would propose that each of these be adapted to a (internal) public interface that accepts and returns standard typing types, and internally converts to our (nowhere else exposed) typehints types, performs the logic, and converts back. Each of these in turn can then be updated, as needed and orthogonally, to operate on the typing types natively (possibly via deference to a third-party library). 

 

I think coder inference could be easily adopted to use typing types directly, but it may be a fourth place where we do internal conversion first. Another gotcha is special care may need to be taken if we ever need to pickle these types (which IIRC may have issues). 

Imported from Jira [BEAM-8156](https://issues.apache.org/jira/browse/BEAM-8156). Original Jira may contain additional context.
Reported by: robertwb.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.