apache / apache/beam

Make RowCoder @Internal

Open
#19,702 0 comments 0 reactions 0 assignees View on GitHub
core improvement java P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

RowCoder is currently public in sdk.coders, tempting people to use it directly. But the Schemas API is written such that everyone should be using SchemaCoder, and RowCoder should be an implementation detail.

Unfortunately this isn't a trivial change, I tried to do it and resolve the few dependencies that cropped up, but running RowCoderTest yielded the following error:

```

tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
java.lang.IllegalAccessError:
tried to access class org.apache.beam.sdk.schemas.RowCoderGenerator$EncodeInstruction from class org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3
at
org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown Source)
at org.apache.beam.sdk.coders.Coder$ByteBuddy$abBJo3R3.encode(Unknown
Source)
at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:159)
at org.apache.beam.sdk.schemas.RowCoder.encode(RowCoder.java:54)
at
org.apache.beam.sdk.coders.Coder.encode(Coder.java:136)
at org.apache.beam.sdk.testing.CoderProperties.encode(CoderProperties.java:334)
at
org.apache.beam.sdk.testing.CoderProperties.decodeEncode(CoderProperties.java:362)
at org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqualInContext(CoderProperties.java:104)
at
org.apache.beam.sdk.testing.CoderProperties.coderDecodeEncodeEqual(CoderProperties.java:94)

```

My attempt is available at https://github.com/TheNeuralBit/beam/commit/869b8c6ba2f554bf56d8df70a754b76ef38dbc89

Imported from Jira [BEAM-7974](https://issues.apache.org/jira/browse/BEAM-7974). Original Jira may contain additional context.
Reported by: bhulette.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.