apache / apache/beam

Refactor LoadTestBuilder.groovy

Open
#19,660 0 comments 0 reactions 0 assignees View on GitHub
P3 tests wish
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

LoadTestBuilder contains some sdk specific logic inside it's methods ("if"'s depending on sdk specific field names, sdk specific pipeline options format, etc).

How we could mitigate that: 
- Have common pojos representing all necessary parameters holding all options/job parameters in the same fields.
- Have one logic for all the operations and split it to more atomic operations. 
- Build options at the end to SDK specific representations.

Imported from Jira [BEAM-7539](https://issues.apache.org/jira/browse/BEAM-7539). Original Jira may contain additional context.
Reported by: ŁukaszG.

Contributor guide

Open the contributing guide

Research direction

Start by reading LoadTestBuilder.groovy and the linked Jira issue BEAM-7539 for the missing context around its SDK-specific logic. Done means introducing common POJOs for the shared parameters, separating the operations into atomic steps, and building SDK-specific option representations only at the end.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.