apache / apache/beam

Encapsulate supplier, monitor and metric naming logic in some common TestMetric type

Open
#19,397 0 comments 0 reactions 0 assignees View on GitHub
improvement P3 tests
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

After an offline discussion together with @mwalenia we decided to create concrete classes for each metric type (Item_count, byte_count, time). Each class like this will contain:
- metric name
- supplier for the metric
- monitor for the metric

It turns out that all this (along with the monitor/supplier can be encapsulated and then attached to the pipeline/metrics reading where needed. This will also encapsulate the naming logic (so that there are no typos again).

Imported from Jira [BEAM-7245](https://issues.apache.org/jira/browse/BEAM-7245). Original Jira may contain additional context.
Reported by: ŁukaszG.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the existing metric, supplier, and monitor naming logic used where pipeline metrics are read; the issue does not name specific files or tests. Use the original BEAM-7245 discussion for context, then define concrete Item_count, byte_count, and time metric types that encapsulate the metric name, supplier, and monitor, with naming handled consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.