apache / apache/beam

Extract RegisterAndProcessBundleOperation constructor parameters into a single class.

Open
#19,371 0 comments 0 reactions 0 assignees View on GitHub
dataflow new feature P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

[https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperation.java#L117](https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperation.java#L117)

 

These constructor parameters play similar role and it might be worth extracting them to a single class that can be passed around.

 

Map ptransformIdToSystemStepContext,
Map ptransformIdToSideInputReader, Map ptransformIdToSideInputReader,
Table\> ptransformIdToSideInputIdToPCollectionView, Table\> ptransformIdToSideInputIdToPCollectionView,
Map sdkToDfePCollectionMapping,

Imported from Jira [BEAM-6834](https://issues.apache.org/jira/browse/BEAM-6834). Original Jira may contain additional context.
Reported by: Ardagan.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.