apache / apache/beam

Improve Beam Fn API Artifact Staging Service Error Handling

Open
#19,130 0 comments 0 reactions 0 assignees View on GitHub
fn-execution improvement java P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

I noticed that the onComplete logic is not wrapped in a try/catch block.  This led to an uncaught NPE in a problem I was debugging.  It also does not log errors, preferring to just use the observer's callback to pass these errors to the SDK.  However some SDKs such as golang's do not surface these errors, and they get lost. 

Imported from Jira [BEAM-5454](https://issues.apache.org/jira/browse/BEAM-5454). Original Jira may contain additional context.
Reported by: axelmagn.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.