apache / apache/beam

Shade conscrypt within the Dataflow legacy worker jar

Open
#19,126 0 comments 0 reactions 0 assignees View on GitHub
bug dataflow P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

org.conscrypt:conscrypt-openjdk:1.1.3:linux-x86_64 relies on JNI which can't be shaded away since the C code doesn't support automatically figuring out its post relocation path (like tcnative can).

There is support for building conscrypt with an additional prefix but this doesn't work well with shading since it requires every user who wants to shade to build their own copy.

jniutil.cc relies on JNI_JARJAR_PREFIX https://github.com/google/conscrypt/blob/e3c1c99b3e0c56849cb7150bb95dc211b0ad058c/common/src/jni/main/cpp/conscrypt/jniutil.cc#L62

Imported from Jira [BEAM-6136](https://issues.apache.org/jira/browse/BEAM-6136). Original Jira may contain additional context.
Reported by: lcwik.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.