apache / apache/beam

Propagate keyed-ness of PValues properly in ReferenceRunner

Open
#19,038 0 comments 0 reactions 0 assignees View on GitHub
bug direct P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

ULR, just like regular direct runner, needs to respect "keyed"-ness of certain PValues, for two purposes: 1) invoking transforms of those PValues serially per key (e.g. because some of such transform evaluators, such as GABW, are not thread-safe per key), and 2) supporting state and timers.

In [https://github.com/apache/beam/pull/5585,](https://github.com/apache/beam/pull/5585,) one of the commits adds such tracking, but only naively - directly on the outputs of GBKO and GABW, without propagating downstream through key-preserving DoFn's.

This Jira is to mimic the behavior of KeyedPValueTrackingVisitor in ULR.

Imported from Jira [BEAM-4557](https://issues.apache.org/jira/browse/BEAM-4557). Original Jira may contain additional context.
Reported by: jkff.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.