apache / apache/beam

Go code should get standard URNs from proto annotations

Open
#18,951 0 comments 0 reactions 0 assignees View on GitHub
go improvement P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

https://github.com/apache/beam/pull/4672 makes standard URNs of various Beam entities be defined in annotations on some enums in the protos. Java and Python now don't hard-code the URNs, instead they get them from the proto annotations.

However, Go still hard-codes the URNs. This JIRA is to make Go do something like what Java and Python do.

(I tried coding this up, but couldn't come up with a good Go API for this - the Java and Python ways don't translate into idiomatic Go as far as I can tell; it's also complicated by the fact that Go protobuf compiler currently doesn't give easy access to enum descriptors: https://github.com/golang/protobuf/issues/364)

Imported from Jira [BEAM-4179](https://issues.apache.org/jira/browse/BEAM-4179). Original Jira may contain additional context.
Reported by: jkff.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.