apache / apache/beam

Local server api descriptors contain urls that work on Mac and Linux

Open
#18,929 0 comments 0 reactions 0 assignees View on GitHub
core improvement P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Docker for Mac does not allow host networking and thus will not allow SDK harnesses to access runner services via `localhost`. Instead, a special DNS name is used to refer to the host machine: docker.for.mac.host.internal. (Note that this value sometimes changes between Docker releases).

We should attempt to detect the host operating system and return different API descriptors based on this.

See [https://github.com/bsidhom/beam/commit/3adaeb0d33dc26f0910c1f8af2821cce4ee0b965](https://github.com/bsidhom/beam/commit/3adaeb0d33dc26f0910c1f8af2821cce4ee0b965) for how this might be done.

Imported from Jira [BEAM-4148](https://issues.apache.org/jira/browse/BEAM-4148). Original Jira may contain additional context.
Reported by: bsidhom.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.