:sdks:go:goVet fails
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 4.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 196
Description
The following fails for me with "./gradlew check":
Execution failed for task ':beam-sdks-go:vet'.
\> Build failed due to return code 1 of:
Command:
/home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet /home/coheig/src/apache/beam/sdks/go/test /home/coheig/src/apache/beam/sdks/go/pkg /home/coheig/src/apache/beam/sdks/go/data /home/coheig/src/apache/beam/sdks/go/cmd /home/coheig/src/apache/beam/sdks/go/build /home/coheig/src/apache/beam/sdks/go/examples /home/coheig/src/apache/beam/sdks/go/container
Env:
GOEXE=
GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath
GOROOT=/home/coheig/.gradle/go/binary/1.10/go
GOOS=linux
GOARCH=amd64
[~herohde] provided more information on the mailing list:
the error is "go vet" itself failing due to analyzing our dependencies under vendor:
/Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47](http://github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47): Fprintln arg list ends with redundant newline
/Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54](http://github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54): unreachable code
/Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276](http://github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276): unreachable code
[...]
Not sure whether this is something we can fix in our configuration or whether it's rather a bug in the gogradle plugin. Given that there are no go vet problems in our code, we'd want that check to pass.
Imported from Jira [BEAM-4422](https://issues.apache.org/jira/browse/BEAM-4422). Original Jira may contain additional context.
Reported by: coheigea.
Contributor guide
Assessment
This issue has not been assessed yet.