apache / apache/beam

FileChannel instance should be closed in ArtifactServiceStager#StagingCallable#get

Open
#18,797 0 comments 0 reactions 0 assignees View on GitHub
bug core P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

```

FileChannel channel = new FileInputStream(file).getChannel();
ByteBuffer readBuffer =
ByteBuffer.allocate(bufferSize);
while (!responseObserver.isTerminal() && channel.position()
< channel.size()) {
readBuffer.clear();
channel.read(readBuffer);

```

The channel should be closed before returning from get()

Imported from Jira [BEAM-3935](https://issues.apache.org/jira/browse/BEAM-3935). Original Jira may contain additional context.
Reported by: yuzhihong@gmail.com.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.