apache / apache/beam

Migrate common_job_properties.groovy to use Maps for keyword argument style calls instead of positional arguments

Open
#18,768 0 comments 0 reactions 0 assignees View on GitHub
good first issue improvement P3 tests
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

This follows the the style defined within [build_rules.gradle](https://github.com/apache/beam/blob/684fb9f974e1b007544d6e9d57fcf99be355e99e/build_rules.gradle#L397) as it is much simpler to read the following method with keyword arguments:
setCommonJobProperties(context: context, maxWorkers: 3)

This also simplifies the usage of methods with multiple default arguments.

Imported from Jira [BEAM-4235](https://issues.apache.org/jira/browse/BEAM-4235). Original Jira may contain additional context.
Reported by: lcwik.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.