apache / apache/beam

PipelineTranslationTest.testProtoAgainstRehydrated() over-validates translated proto structure

Open
#18,752 0 comments 0 reactions 0 assignees View on GitHub
bug core P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

PipelineTranslationTest.testProtoAgainstRehydrated() validates round-tripping of a Pipeline object to and form proto, verifying each of the rehydrated fields. From conversations with [~lcwik], the validation logic is over-specified. There is no requirement that equivalent objects are serialized using the same ID. So iterating to find the set of unique IDs and validating the count is incorrect.

Imported from Jira [BEAM-4284](https://issues.apache.org/jira/browse/BEAM-4284). Original Jira may contain additional context.
Reported by: swegner.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.