Change PTransformOverride.get_matcher() to PTransformOverride.matches(AppliedTransform)
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 4.7k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 205
Description
This will simplify the interface.
PTransformOverride.matches() should be a efficient check to determine if a given transform should be replaced while PTransformOverride.get_replacement_transform() should generate and return the actual replacement.
Imported from Jira [BEAM-3614](https://issues.apache.org/jira/browse/BEAM-3614). Original Jira may contain additional context.
Reported by: chamikara.
Contributor guide
Research direction
Start by locating the PTransformOverride interface and all uses of get_matcher(), matches(), and get_replacement_transform(). Review the linked BEAM-3614 Jira issue for additional context. Done means the interface uses matches(AppliedTransform) for efficient eligibility checks and get_replacement_transform() creates the replacement transform.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100