apache / apache/beam

isort and pylint conflicting rules

Open
#18,632 0 comments 1 reaction 0 assignees View on GitHub
core improvement P3 python
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
2d 2h
Merged PRs (30d)
205

Description

isort places "import ..." statements before "from ... import ..." statements. This sometimes triggers the ungrouped-imports rule in pylint.

 

Since isort cannot be configured, the easiest way to resolve this would be to disable the pylint rule. It would also be good to remove the respective inline pylint comments as well.

Imported from Jira [BEAM-3745](https://issues.apache.org/jira/browse/BEAM-3745). Original Jira may contain additional context.
Reported by: luke-zhu.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Python lint configuration for pylint's ungrouped-imports rule and the inline pylint comments mentioned in the issue. Disable the conflicting rule and remove the corresponding comments; done means isort ordering no longer triggers this pylint warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.